Fix Coverity issues #193
Fix Coverity issues #193
Conversation
sysopenci
added
Pending Developer Approval
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
YuanjunHuang and
yyao3
sysopenci
removed request for
yyao3,
gkdeepa,
YuanjunHuang,
TianmiChen and
dyang23
| @@ -2177,19 +2177,20 @@ void MfxC2DecoderComponent::DoWork(std::unique_ptr<C2Work>&& work) | |||
| if (it != m_pendingWorks.end()) { | |||
| work = std::move(it->second); | |||
| m_pendingWorks.erase(it); | |||
|
|
|||
| if (work) { | |||
There was a problem hiding this comment.
Could you please explain why we move the logic here?
Thanks,
Tianmi
There was a problem hiding this comment.
I have updated it. Please review again.
Thanks,
Hao
harvan
force-pushed
the
hao-dev-OAM-126078
branch
from
8e1ad6f to
af759a0
Compare
sysopenci
added
Valid commit message
and removed
Valid commit message
PR approved
labels
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
YuanjunHuang and
yyao3
|
@TianmiChen @feijiang1 @YuanjunHuang Please review. |
sysopenci
added
Developer Approved
and removed
Pending Developer Approval
|
Android CI has started Engineering Build for this issue ,Please check the linked Tracked-On issue/Android CI Web for more details. |
|
SUCCESS: Android CI has completed Engineering Build for this issue.Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
added
Engineering Build Successful
CID/Type: 187157 Explicit null dereferenced 656172 Dereference after null check 602228 Dereference before null check Tracked-On: OAM-126078 Signed-off-by: Wan, Hao <[email protected]>
|
Android CI has started MERGE Build for this pr ,Please check the linked Tracked-On issue/Android CI Web for more details. |
sysopenci
merged commit 1c6ccea
into
projectceladon:celadon/u/mr0/master
|
Android CI has completed MERGE Build for this pr, build is FAILURE. Please check the linked Tracked-On issue/Android CI Web for more details. |
CID/Type:
187157 Explicit null dereferenced
656172 Dereference after null check
602228 Dereference before null check
Tracked-On: OAM-126078